fix: ignored objects should be excluded from fingerprint calc#108
Merged
fix: ignored objects should be excluded from fingerprint calc#108
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #107 by ensuring that ignored objects are excluded from fingerprint calculations. The main changes consolidate two database IR retrieval functions into one that always accepts an ignore configuration parameter.
- Merged
GetIRFromDatabaseandGetIRFromDatabaseWithIgnoreConfiginto a single function - Updated fingerprint validation in the apply command to use ignore configuration
- Enhanced integration tests to verify ignored objects are properly excluded from fingerprints
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| cmd/util/connection.go | Consolidated two functions into one GetIRFromDatabase that accepts ignore config parameter; reorganized imports |
| cmd/plan/plan.go | Updated function call to use consolidated GetIRFromDatabase; reorganized imports and removed blank line |
| cmd/apply/apply.go | Added ignore config loading before fingerprint validation and passed it to validation function; removed blank line |
| cmd/ignore_integration_test.go | Expanded test to verify ignored objects are excluded from fingerprint calculation with comprehensive schema and verification |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #107